feat: add toggleable certificates#13
Merged
Merged
Conversation
MoisesGSalas
force-pushed
the
mgs/auto-tls
branch
from
ce9977d to
9cd5774
Compare
Contributor
|
can we explain the implications of removing the setting in those places? |
mariajgrimaldi
approved these changes
Oct 5, 2022
MoisesGSalas
force-pushed
the
mgs/auto-tls
branch
from
9cd5774 to
183178a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the option to only define the ingress route without the need of cert-manager provided certificates.
The idea is to decouple the certificate management of the ingress from the
ENABLE_HTTPSvariable.