feat: render global environment outside tutor-env#5
Merged
Conversation
mariajgrimaldi
commented
Aug 2, 2022
mariajgrimaldi
commented
Aug 2, 2022
MoisesGSalas
reviewed
Aug 2, 2022
mariajgrimaldi
commented
Aug 3, 2022
090ff42 to
ad5c31e
Compare
MoisesGSalas
reviewed
Aug 3, 2022
| version: {{ DRYDOCK_PROMETHEUS_VERSION }} | ||
| releaseName: prometheus | ||
| includeCRDs: true | ||
| {%- if DRYDOCK_PROMETHEUS_VALUES | default(false) %} |
Member
There was a problem hiding this comment.
I'm thinking of not using default here and instead having them in the defaults.yml file? That way we can refer to that file to know what variables are available.
9f783b5 to
3e1af40
Compare
MoisesGSalas
reviewed
Aug 8, 2022
15bcd83 to
890f233
Compare
Contributor
Author
|
hey! what do you think now? @jfavellar90 @MoisesGSalas |
MoisesGSalas
approved these changes
Aug 10, 2022
881f7d4 to
d9b7c5c
Compare
jfavellar90
approved these changes
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new manifest builder that generates manifests outside the usual tutor environment, which are meant to be used to create global resources for a cluster.
How to test
Generate a drydock environment using a reference with the GlobalManifests builder, e.g:
After running
tutor drydock save -r drydock-reference.yml, a new env called global-env will be generated with the customization file rendered