Skip to content

feat: split ingress per host, add patch to add lms extra hosts#50

Merged
Henrrypg merged 8 commits into
mainfrom
hpg/change-ingress
Nov 7, 2023
Merged

feat: split ingress per host, add patch to add lms extra hosts#50
Henrrypg merged 8 commits into
mainfrom
hpg/change-ingress

Conversation

@Henrrypg
Copy link
Copy Markdown
Contributor

@Henrrypg Henrrypg commented Nov 2, 2023

Description

This PR intends to:

  • Split Ingress Resources per service/host
  • Add DRYDOCK_BYPASS_CADDY variable to pass directly to the service of each ingress
  • Add drydock-lms-ingress-rules and drydock-lms-ingress-tls-hosts patches to add extra lms hosts and tls.

You can look for this argo env to see the changes made with this branch

NOTES:

  1. We need to manually delete the older ingress resources due to ArgoCD try to create the new ones first to remove the older, so it fails due to duplicated hosts.
  2. I made this change to avoid the strict error in our current installations that has notes, minio extra hosts, something like a "Warning" to be deprecated in the future.

@Henrrypg Henrrypg requested a review from a team as a code owner November 2, 2023 16:30
Comment thread drydock/templates/drydock/k8s/ingress/extra-hosts.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/issuer.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/lms.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/lms.yml
Comment thread drydock/templates/drydock/k8s/ingress/minio.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/cms.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/cms.yml
Comment thread drydock/templates/drydock/k8s/ingress/lms.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/issuer.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/lms.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/cms.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/lms.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/lms.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/mfe.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/mfe.yml
Comment thread drydock/plugin.py Outdated
Comment thread drydock/templates/drydock/k8s/ingress/extra-hosts.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/lms.yml Outdated
Comment thread drydock/templates/drydock/k8s/ingress/lms.yml
@Henrrypg Henrrypg merged commit 0401123 into main Nov 7, 2023
@Henrrypg Henrrypg deleted the hpg/change-ingress branch November 7, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants