Skip to content

feat: support docker operations for image in drydock backups#53

Merged
jfavellar90 merged 6 commits into
mainfrom
mar/tutor-images
Nov 29, 2023
Merged

feat: support docker operations for image in drydock backups#53
jfavellar90 merged 6 commits into
mainfrom
mar/tutor-images

Conversation

@marbonilla
Copy link
Copy Markdown
Contributor

@marbonilla marbonilla commented Nov 23, 2023

Description

This PR enables the ability to build and push the shipyard-utils image using tutor

How to test it?

After installing the drydock-backups plugin, you can test the Docker operations BUILD PULL and PUSH using the tutor images [operation] backups command.

@marbonilla marbonilla requested a review from a team as a code owner November 23, 2023 22:44
Comment thread drydock_backups/plugin.py Outdated
Comment thread drydock_backups/plugin.py Outdated
Comment thread drydock_backups/plugin.py Outdated
Comment thread drydock_backups/plugin.py Outdated
Comment thread drydock_backups/templates/drydock-backups/.gitignore Outdated
Comment thread drydock_backups/plugin.py Outdated
Comment thread drydock_backups/README.rst Outdated
Comment thread .gitignore
Copy link
Copy Markdown
Contributor

@Henrrypg Henrrypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Once suggestion was solved

@jfavellar90
Copy link
Copy Markdown
Member

@marbonilla should we bump Drydock version? At this moment the drydock-backups version is tied to the drydock version, a fact that I don't like very much. I'd propose bumping the drydock version to close this PR and discuss the backups plugin versioning matter in a different PR

@jfavellar90 jfavellar90 merged commit 07d0371 into main Nov 29, 2023
@jfavellar90 jfavellar90 deleted the mar/tutor-images branch November 29, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants