Skip to content

feat: add a job to initialize mongodb users#60

Merged
MoisesGSalas merged 1 commit into
mainfrom
mgs/add-mongodb-init
Jan 10, 2024
Merged

feat: add a job to initialize mongodb users#60
MoisesGSalas merged 1 commit into
mainfrom
mgs/add-mongodb-init

Conversation

@MoisesGSalas
Copy link
Copy Markdown
Member

Description

Include an initialization job similar to the MySQL one that creates a MongoDB user with the necessary permissions. To simplify things a bit we use the same user for edxapp and forum and remove the need for the forum-overrides patch. This assumes an admin user is already present on your MongoDB instance and can be accessed via MONGODB_ROOT_USERNAME and MONGODB_ROOT_PASSWORD.

@MoisesGSalas MoisesGSalas requested a review from a team as a code owner January 9, 2024 12:02
@MoisesGSalas MoisesGSalas requested a review from a team January 9, 2024 12:02
@Henrrypg
Copy link
Copy Markdown
Contributor

Henrrypg commented Jan 9, 2024

Can we add the BACKUP user?

@Henrrypg
Copy link
Copy Markdown
Contributor

Henrrypg commented Jan 9, 2024

It works with backup role

@MoisesGSalas
Copy link
Copy Markdown
Member Author

@Henrrypg, I think the creation of the backup user might be better handled by the backup plugin.

We could do two things: we can define almost the same job in the backup plugin. or we can define a new patch to add additional instructions to the job.

I think the patch might be a better fit.

Comment thread drydock/plugin.py Outdated
Comment thread drydock/templates/drydock/k8s/drydock-jobs/mongodb.yml Outdated
Include an initialization job similar to the MySQL one that creates a
mongodb user with the necessary permissions. To simplify things a bit we
use the same user for edxapp and forum and remove the need for the
forum-overrides patch.
@MoisesGSalas MoisesGSalas merged commit c19ae63 into main Jan 10, 2024
@jfavellar90
Copy link
Copy Markdown
Member

I want to backport this to Olive. However, we must adjust the release workflow since it does not work properly. @Henrrypg could we do a manual release? the branch to apply the changes to is called olmo-release.

@MoisesGSalas MoisesGSalas deleted the mgs/add-mongodb-init branch January 10, 2024 20:38
@Henrrypg Henrrypg restored the mgs/add-mongodb-init branch January 10, 2024 21:33
@Henrrypg Henrrypg deleted the mgs/add-mongodb-init branch January 10, 2024 21:36
Henrrypg pushed a commit that referenced this pull request Jan 10, 2024
Include an initialization job similar to the MySQL one that creates a
mongodb user with the necessary permissions. To simplify things a bit we
use the same user for edxapp and forum and remove the need for the
forum-overrides patch.
@Henrrypg
Copy link
Copy Markdown
Contributor

@jfavellar90 backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants