Fix discussion API topic filtering in Teak release#318
Merged
Conversation
* fix: stoped group TA to see the posts of other cohorts * test: updated test cases --------- Co-authored-by: Ayesha Waris <ayesha.waris@192.168.10.31>
This will force the use of the new v2 forums API for pinning/unpinning.
This will force the use of the new v2 forum's APIs for flaging/unflaging.
This will force the use of the new v2 forum's APIs for voting/unvoting.
This PR fixes following filter on the discussions module by replacing forum api to api since we only need threads that are subscribed/followed by the requesting user.
This will force the use of the new v2 forum's APIs for searching.
- This will force the use of the new v2 forum's APIs for subscriptions.
magajh
approved these changes
May 25, 2026
DeimerM
added a commit
that referenced
this pull request
May 25, 2026
) * fix: stoped group TA to see the posts of other cohorts (openedx#36765) * fix: stoped group TA to see the posts of other cohorts * test: updated test cases --------- * feat!: remove cs_comments_service support for forums pin API This will force the use of the new v2 forums API for pinning/unpinning. * feat!: remove cs_comments_service support for forum's flag APIs This will force the use of the new v2 forum's APIs for flaging/unflaging. * feat!: remove cs_comments_service support for forum's vote APIs This will force the use of the new v2 forum's APIs for voting/unvoting. * fix: Discussion following posts filter This PR fixes following filter on the discussions module by replacing forum api to api since we only need threads that are subscribed/followed by the requesting user. * feat!: remove cs_comments_service support for forum's search APIs This will force the use of the new v2 forum's APIs for searching. * feat!: remove cs_comments_service support for forum's subscription APIs - This will force the use of the new v2 forum's APIs for subscriptions. --------- Co-authored-by: ayesha waris <73840786+ayesha-waris@users.noreply.github.com> Co-authored-by: Ayesha Waris <ayesha.waris@192.168.10.31> Co-authored-by: Taimoor Ahmed <68893403+taimoor-ahmed-1@users.noreply.github.com> Co-authored-by: Ali-Salman29 <ali.salman@arbisoft.com> Co-authored-by: Taimoor Ahmed <taimoor.ahmed@A006-01711.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A bug was identified in the Teak release where discussions were not displaying correctly. Specifically, when a post was created within a discussion linked to a related topic, clicking on that topic failed to show the discussion.
This issue is regression-specific to the Teak release; the Ulmo release functions as expected.
Solution
To resolve this, I compared the Teak codebase with Ulmo. The Ulmo release included API refactoring to support Forum V2. I identified the relevant commits and cherry-picked the non-conflicting fixes that resolve this behavior without introducing unwanted new features to the Teak release.
Backports
The following backports were applied in order to fix this issue:
How to Test