Fix M4 (operator<< moved inside OpenABF namespace)#33
Merged
csparker247 merged 1 commit intodevelopfrom Mar 16, 2026
Merged
Conversation
operator<< for Vec was defined after the closing namespace brace. Moved inside the OpenABF namespace for correctness and clarity. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
csparker247
force-pushed
the
worktree-agent-a6e6ce96
branch
from
bdffbbb to
b75b264
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operator<<forVecwas defined after the closing brace of theOpenABFnamespace. While ADL handles this in practice, it is cleaner and more correct to define it inside the namespace. Moved the definition insideOpenABF, removing the now-unnecessaryOpenABF::qualification from the parameter type.Test plan
ctest100%)Closes #28