Fix M3: rename detail::erase_if to detail::filter#35
Merged
csparker247 merged 1 commit intodevelopfrom Mar 16, 2026
Merged
Conversation
The function takes a container by value and returns a filtered copy, which conflicts with the std::erase_if naming convention (in-place). Renamed to detail::filter to accurately reflect copy semantics. All 6 call sites updated. Library targets C++17 so a named helper is appropriate in lieu of std::ranges::filter_view (C++20). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
csparker247
added a commit
that referenced
this pull request
Mar 16, 2026
Resolved via PR #35 (renamed detail::erase_if to detail::filter). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detail::erase_iftakes its container by value, filters it, and returns the filtered copy. The name conflicts withstd::erase_if(C++20), which mutates in-place — misleading any reader familiar with the standard algorithm.Renamed to
detail::filterto accurately reflect the copy semantics. The library targets C++17, so keeping a named helper is appropriate in lieu ofstd::ranges::filter_view.All 7 occurrences updated (1 definition + 6 call sites in
HalfEdgeMesh.hpp). No behavioral change.Test plan
ctest100%)Closes #27