feat: add configurable gradient threshold to ABF and ABFPlusPlus (A1)#40
Merged
csparker247 merged 1 commit intodevelopfrom Mar 16, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setGradientThreshold(T)method to bothABFandABFPlusPlusalongside the existingsetMaxIterations()gradThresholdparameter (defaulting toT(0.001)) to the full staticCompute()overload on both classes0.001literal in the solverwhileloop with the configurable parameterTest plan
ABFPlusPlus_TightThreshold: tightening threshold to 1e-6 produces a lower final gradient than the defaultABFPlusPlus_LooseThreshold: threshold of 1e6 (above initial gradient) causes zero solver iterationsCloses #15
🤖 Generated with Claude Code