Fix open review comments on MeshIO PR#18
Merged
csparker247 merged 2 commits intofeature/mesh-io_20260323from Apr 23, 2026
Merged
Fix open review comments on MeshIO PR#18csparker247 merged 2 commits intofeature/mesh-io_20260323from
csparker247 merged 2 commits intofeature/mesh-io_20260323from
Conversation
- conductor/product.md: trim goal #4 to one line (remove vertex-trait detail per suggestion) - Math.hpp: cross() error message → "Inputs must be 3-dimensional" - String.hpp: add comment confirming predicate-overload dispatch at line 266 - cmake/CheckCharconvFP.cmake: collect fallback defs into EDUCE_CORE_CHARCONV_DEFS list instead of add_compile_definitions; caller applies them via target_compile_definitions - CMakeLists.txt: target_compile_definitions(core PUBLIC ${EDUCE_CORE_CHARCONV_DEFS}) so definitions propagate automatically to downstream targets - README.md: update charconv section — correct per-type definition names, show automatic propagation via target_link_libraries, keep header-only manual example - MeshIO_PLY.hpp: introduce PLYType enum + parse_ply_type(); replace std::string type / list_count_type fields in PLYProp; convert ply_type_bytes, read_ply_binary_prop, read_ply_prop_from_buf to switch-on-enum dispatch - MeshIO_PLY.hpp: use trim_right (string_view) in skip_ascii_line, vertex ASCII loop, and face ASCII loop instead of trim_right_in_place - MeshIO_PLY.hpp: color-type conditions use PLYType::UChar / PLYType::UShort only (remove signed char/short cases that could produce incorrect casts) Agent-Logs-Url: https://github.com/educelab/libcore/sessions/7a14eef7-28d9-4b16-98ba-a8ef620e0c9f Co-authored-by: csparker247 <1434526+csparker247@users.noreply.github.com>
Agent-Logs-Url: https://github.com/educelab/libcore/sessions/7a14eef7-28d9-4b16-98ba-a8ef620e0c9f Co-authored-by: csparker247 <1434526+csparker247@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
csparker247
April 23, 2026 19:01
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all unresolved review comments on the MeshIO implementation PR.
MeshIO_PLY.hppPLYTypeenum replacesstd::stringforPLYProp::typeandlist_count_type;parse_ply_type()converts header tokens at parse time.ply_type_bytes,read_ply_binary_prop, andread_ply_prop_from_bufnow dispatch viaswitchinstead of sequential string comparisonsPLYType::UChar/PLYType::UShort; removed signedchar/shortcases that could produce incorrect casts for negative valuestrim_right(string_view) replacestrim_right_in_placein all three ASCII read loops; the trimmedstring_viewis passed directly tosplit, avoiding a redundant castCMake charconv probes
CheckCharconvFP.cmakenow appends needed definitions toEDUCE_CORE_CHARCONV_DEFSinstead of callingadd_compile_definitionsCMakeLists.txtapplies them viatarget_compile_definitions(core PUBLIC ...), so they propagate automatically to any downstream target viatarget_link_librariesMiscellaneous
Math.hpp:cross()error message →"Inputs must be 3-dimensional"String.hpp: comment at predicate-dispatch call site clarifying it routes to theis_invocable_r_v-constrained overload, not back into the variadic templateREADME.md: charconv section updated with correct per-type definition names (EDUCE_CORE_NEED_FROM/TO_CHARS_{FLOAT,DOUBLE,LONG_DOUBLE}) and revised cmake example reflecting automatic propagationconductor/product.md: trimmed goal (String) Add partition and to_padded_string #4 per suggestion