This repository was archived by the owner on Dec 6, 2025. It is now read-only.
Merged
Conversation
- Connect / Disconnnect button text is now based on on-demand-ness
- When contacting the server for checking the certificate
- Connect / Disconnnect button is disabled
- Back button is disabled
- Spinner spins
- If on-demand is on
- Back button is disabled
- Connect / Disconnnect button text is now based on on-demand-ness
- When contacting the server for checking the certificate
- Connect / Disconnnect button is disabled
- Close button is disabled, connection VC can't be swiped down
- If on-demand is on
- Close button is disabled, connection VC can't be swiped down
If startTunnel fails, the errors should get propagated through the Promise-s, so that code can respond to the failure accordingly.
So that the user knows something's happening, especially when we're doing a check_certificate.
cyberjoost
approved these changes
Jun 2, 2020
Contributor
cyberjoost
left a comment
cyberjoost
left a comment
There was a problem hiding this comment.
Tested and added a little patch/commit.
johankool
approved these changes
Jun 3, 2020
This was referenced Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #90 - in case the certificate expires while the VPN is up, we should be able to stop the tunnel with the app. Currently, that’s not always possible because:
This PR addresses the above concerns but also makes some additional fixes. (Hence a separate PR.)