docs: soften jquery-bbq attribution to reflect v1.1.0 rewrite#6
Merged
Conversation
After v1.1.0 the deparam side is an original qs-backed shim, not bbq-derived code. The LICENSE previously claimed lib/deparam.js was "adapted from" jquery-bbq, which became inaccurate at the shim swap. Update both LICENSE and README to reflect that: - param.js is still adapted from jQuery's $.param (unchanged since 2014). - deparam.js is now an original shim; the bbq lineage is in its behavioral contract (coercion conventions, test fixtures, ISO-8859 fallback semantics), not its source code. No code change. No version bump needed (LICENSE/README ship in the tarball but the attribution correction doesn't affect runtime behavior).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two-file docs change. After v1.1.0 the deparam side is an original qs-backed shim — no jquery-bbq code remains in the shipped tarball. The LICENSE previously claimed
lib/deparam.jswas "adapted from" jquery-bbq, which became inaccurate at the shim swap.This MR updates both LICENSE and README to reflect reality:
param.jsis still adapted from jQuery's$.param. Attribution stays as-is.deparam.jsis now an original shim. The jquery-bbq lineage lives in its behavioral contract (coercion conventions, test fixtures withbbq specslabels, ISO-8859 percent-encoding fallback semantics) — not its source code. Attribution wording softened from "adapted from" to "behavioral conventions preserved from."No code change
Library source untouched. No version bump needed — LICENSE and README ship in the tarball, but a wording correction in attribution doesn't change runtime behavior. Merge to main, no publish.
Test plan