Skip to content

chore: Added node and playwright installation steps in Dockerfile#282

Merged
srathod-apphelix merged 1 commit intomasterfrom
srathod/BOMS_221_e2e_playwright_tests_pipeline
Oct 27, 2025
Merged

chore: Added node and playwright installation steps in Dockerfile#282
srathod-apphelix merged 1 commit intomasterfrom
srathod/BOMS_221_e2e_playwright_tests_pipeline

Conversation

@srathod-apphelix
Copy link
Copy Markdown
Member


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

Copilot AI review requested due to automatic review settings October 27, 2025 09:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Node.js 20.x and Playwright installation to the GitHub Actions runner Docker image to enable browser-based testing capabilities.

Key Changes:

  • Added Node.js 20.x installation using NodeSource repository
  • Installed Playwright globally with browser binaries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +44 to +45
RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - \
&& apt-get install -y nodejs
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The curl command pipes directly to bash without verification. Consider adding checksum verification or using a specific version hash to ensure the integrity of the installation script before execution.

Suggested change
RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - \
&& apt-get install -y nodejs
RUN apt-get update && apt-get install -y gnupg dirmngr \
&& cd /tmp \
&& curl -fsSLO https://deb.nodesource.com/setup_20.x \
&& curl -fsSLO https://deb.nodesource.com/setup_20.x.asc \
&& export GNUPGHOME="$(mktemp -d)" \
&& gpg --keyserver keyserver.ubuntu.com --recv-keys 1655A0AB68576280 \
&& gpg --verify setup_20.x.asc setup_20.x \
&& bash setup_20.x \
&& apt-get install -y nodejs \
&& rm -rf "$GNUPGHOME" /tmp/setup_20.x /tmp/setup_20.x.asc

Copilot uses AI. Check for mistakes.
&& apt-get install -y nodejs

# Install global Playwright CLI and pre-download required browser binaries
RUN npm install -g playwright && npx playwright install --with-deps
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing Playwright without specifying a version may lead to inconsistent builds. Consider pinning to a specific version (e.g., 'playwright@1.40.0') to ensure reproducible builds and avoid unexpected breaking changes.

Suggested change
RUN npm install -g playwright && npx playwright install --with-deps
RUN npm install -g playwright@1.40.0 && npx playwright install --with-deps

Copilot uses AI. Check for mistakes.
Comment on lines +44 to +48
RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - \
&& apt-get install -y nodejs

# Install global Playwright CLI and pre-download required browser binaries
RUN npm install -g playwright && npx playwright install --with-deps
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple RUN commands increase Docker layer size and build time. Consider combining these into a single RUN command with apt-get clean and removal of package lists to reduce the final image size.

Copilot uses AI. Check for mistakes.
@srathod-apphelix srathod-apphelix merged commit 3485390 into master Oct 27, 2025
3 checks passed
@srathod-apphelix srathod-apphelix deleted the srathod/BOMS_221_e2e_playwright_tests_pipeline branch October 27, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants