Conversation
It was being ignored because this is supposed to be a top-level option, not a subcommand option.
robrap
approved these changes
Feb 18, 2026
timmc-edx
added a commit
that referenced
this pull request
Feb 18, 2026
This reverts commits 270a106/PR #318, ba8d06d/PR #319, and 133403d/PR #320 which attempted to change to running git-clean as root. For some reason, git is still saying the directory is unsafe and recommends setting `safe.directory` even though we already are. Just giving up for now. We may need some other approach, such as running `chown -R` on the repo before cleaning or ensuring these files are created with the right ownership in the first place.
3 tasks
timmc-edx
added a commit
that referenced
this pull request
Feb 18, 2026
This reverts commits 270a106/PR #318, ba8d06d/PR #319, and 133403d/PR #320 which attempted to change to running git-clean as root. For some reason, git is still saying the directory is unsafe and recommends setting `safe.directory` even though we already are. Just giving up for now. We may need some other approach, such as running `chown -R` on the repo before cleaning or ensuring these files are created with the right ownership in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was being ignored because this is supposed to be a top-level option, not a subcommand option.
Make sure that the following steps are done before merging: