fix: move default audio codec setting earlier to init correctly #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelroytman
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR reorders initialization code in the HLS video player to set the default audio codec configuration before calling the common initialization method. This improves the logical flow by ensuring all configuration defaults are established before initialization proceeds.
- Moved the
defaultAudioCodecconfiguration setup to occur before thethis.init(el, config)call
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jristau1984
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hopeful fix for #19 , moves
defaultAudioCodecconfig earlier in initialization to set correctly.Deadline
ASAP