fix: ENT-11771 SAML login - Allow email editing if emtpy#255
Merged
Conversation
c81396e to
151f0d5
Compare
There was a problem hiding this comment.
Pull request overview
This PR adjusts SAML SSO registration behavior so that disable_email_editing=True only makes the email field read-only when the SAML pipeline actually provides a non-empty email value—allowing users to enter an email when the IdP doesn’t supply one.
Changes:
- Gate the “email readonly” override behind the presence of a non-empty
emailvalue fromget_register_form_data. - Add a regression test ensuring the email field remains editable when no email is provided by the pipeline (even if
disable_email_editing=True).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openedx/core/djangoapps/user_authn/views/registration_form.py | Only applies the email readonly restriction when the provider-supplied email is non-empty. |
| openedx/core/djangoapps/user_authn/views/tests/test_saml_disable_email_editing.py | Adds coverage for the “disable editing but missing email” scenario to prevent regressions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
151f0d5 to
6b0d539
Compare
macdiesel
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow up to make email editable if blank.
ENT-11771