fix: resolved “Load more comments” button not rendering issue#261
Merged
Conversation
Alam-2U
changed the title
There was a problem hiding this comment.
Pull request overview
This PR addresses a pagination metadata bug in the discussions REST API that prevented the UI from rendering the “Load more comments” control for response child-comments by ensuring num_pages is calculated from the full child-comment set rather than just the current page.
Changes:
- Compute pagination
num_pagesusing the total number of child comments (len(response_comments)) instead of the page slice length. - Pass the total child-comment count into
DiscussionAPIPaginationso pagination metadata can reflect additional available pages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rahulkanneri-2u
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the “Load more comments” button was not rendering in discussion threads, preventing users from viewing additional comments beyond the initial set.
Root Cause
The rendering logic for the pagination control was not being triggered correctly, causing the “Load more comments” button to not appear even when more comments were available
Ticket
COSMO2-889