fix: Update pull_translations to include additional sources and imports#8
Open
rpipaliya-sonata wants to merge 1 commit into
Open
fix: Update pull_translations to include additional sources and imports#8rpipaliya-sonata wants to merge 1 commit into
rpipaliya-sonata wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Makefile translation pull workflow to better support Atlas-based translation imports for this frontend app and allow downstream customization.
Changes:
- Adds configurable Atlas variables for extra sources, extra intl imports, and Atlas options.
- Updates the Atlas source/import target from program-manager to program-console.
- Appends externally supplied translation sources/imports to the pull workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 25845090840Coverage remained the same at 55.335%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the translation pulling process in the
Makefileto improve flexibility and support for additional sources. The main changes involve parameterizing extra translation sources and imports, and updating the list of supported frontend apps.Translation process improvements:
ATLAS_EXTRA_SOURCES,ATLAS_EXTRA_INTL_IMPORTS,ATLAS_OPTIONS) to allow specifying additional translation sources and imports externally, such as fromedx-internal.frontend-app-program-consoleinstead offrontend-app-program-manager, and to append any extra sources/imports provided via the new variables.JIRA