fix: mysql error during deployment#14
Merged
Faraz32123 merged 1 commit intomainfrom Nov 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a MySQL connection error that occurs during deployment when Django management commands (specifically make pull_translations) attempt to evaluate a waffle flag at import time before the database is available. The fix wraps the waffle flag check in a try/except block to gracefully handle database connection failures by defaulting to False.
Key Changes:
- Version bump from 1.0.1 to 1.0.2
- Added exception handling around
ENABLE_GAMES_XBLOCK.is_enabled()to prevent deployment failures when the database is unavailable
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| setup.py | Version bumped to 1.0.2 for the bug fix release |
| games/toggles.py | Added try/except block around waffle flag check to handle database connection errors during deployment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
papphelix
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
error trace:
https://gocd.tools.edx.org/go/tab/build/detail/build_edxapp_amis/7612/run_play/2/stage_edx