Feat: matching student view#2
Merged
tpreston2u merged 5 commits intomainfrom Jul 24, 2023
Merged
Conversation
tpreston2u
requested review from
KristinAoki,
bszabo,
connorhaugh,
jesperhodge,
kenclary and
rayzhou-bit
rayzhou-bit
reviewed
Jul 16, 2023
rayzhou-bit
left a comment
rayzhou-bit
left a comment
There was a problem hiding this comment.
You should get the flashcard PR merged first before doing any more work on this one. You will probably need to rebase this PR after you merge the flashcard PR. The .pyc files should be left out of this PR too.
Comment on lines
+351
to
+358
| self.matching_id_dictionary_index[self.matching_id_list[i]] = i//2 | ||
| self.matching_id_dictionary_index[self.matching_id_list[i+1]] = i//2 | ||
|
|
||
| self.matching_id_dictionary_type[self.matching_id_list[i]] = "term" | ||
| self.matching_id_dictionary_type[self.matching_id_list[i+1]] = "definition" | ||
|
|
||
| self.matching_id_dictionary[self.matching_id_list[i]] = self.list[i//2]['term'] | ||
| self.matching_id_dictionary[self.matching_id_list[i+1]] = self.list[i//2]['definition'] |
There was a problem hiding this comment.
Would these make more sense to store this in a format like:
{
'ABCDEF': {
type: 'term',
id: 0,
},
'GHIJKL': {
type: 'definition',
id: 0,
}
}
rayzhou-bit
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates the matching game student view.
See #1 for information about how to test the code.