fix!: Use new, non-colliding UID and GID for codejail app, sandbox users#113
Merged
fix!: Use new, non-colliding UID and GID for codejail app, sandbox users#113
Conversation
8 tasks
- Don't bother deleting `ubuntu` user, as we won't be needing the UID 1000 any more. - While we're in these lines, remove unneeded braces from variable interpolation. They just create longer lines, here, and aren't actually needed for delimiting. - Don't create user home for app user -- wasn't needed. Part of edx/edx-arch-experiments#983 and see openedx/codejail-service#30 for new docs.
robrap
reviewed
Mar 19, 2025
| # RLIMIT_NPROC UID-global usage pool, and Docker not isolating UIDs.) | ||
| # | ||
| # Selected via: python3 -c 'import random; print(random.randrange(3000, 2 ** 31))' | ||
| ARG APP_UID_GID=206593644 |
There was a problem hiding this comment.
I was confused at first, even though this should be obvious. What if you have APP_UID and APP_GID separate, and just set the second to the first (either using the variable or repeating the id)?
Member
Author
There was a problem hiding this comment.
Sure, that would be reasonable.
robrap
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ubuntuuser, as we won't be needing the UID 1000 any more.Part of edx/edx-arch-experiments#983 and see openedx/codejail-service#30 for new docs.