channel ID display and rate limiting to the Kick settings:#158
Closed
id3adeye wants to merge 1 commit intoeerimoq:mainfrom
id3adeye:main
Closed
channel ID display and rate limiting to the Kick settings:#158id3adeye wants to merge 1 commit intoeerimoq:mainfrom id3adeye:main
id3adeye wants to merge 1 commit intoeerimoq:mainfrom
id3adeye:main
Conversation
Channel ID Display: Shows the fetched channel ID under the channel name field, or "Channel not found" if invalid Rate Limiting: 2.5-second cooldown on channel name changes to prevent API rate limiting
Owner
|
I think we should start by fetching the channel info in one place in the code base instead of fetching it in multiple places. Once it is fetched, we reload the pusher and potentially show it in the UI. We also use this fetched info when sending chat messages and other API actions (where we today fetch the channel info every time). Let's fetch it when the channel name changes and when the app starts. |
Contributor
Author
|
will re think :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel ID Display: Shows the fetched channel ID under the channel name
field, or "Channel not found" if invalid
Rate Limiting: 2.5-second cooldown on channel name changes to prevent
API rate limiting