added unit test when there is no never timestamp in buffer#185
Closed
nofuture2077 wants to merge 2 commits intoeerimoq:mainfrom
Closed
added unit test when there is no never timestamp in buffer#185nofuture2077 wants to merge 2 commits intoeerimoq:mainfrom
nofuture2077 wants to merge 2 commits intoeerimoq:mainfrom
Conversation
Contributor
Author
|
I don't get why this test runs here. Fails local against your branch. Planned to deactivate it after a failed build |
Owner
|
tests are not run on PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unit test is a demo why I believe so many frames got dropped. In a situation where no new audio frame is available everything is dropped.
It is not an endless loop - but it discards the whole buffer