Refactor Mic#26
Closed
ErAzOr2k wants to merge 3 commits intoeerimoq:mainfrom
ErAzOr2k:main
Closed
Conversation
eerimoq
reviewed
May 14, 2024
Owner
eerimoq
left a comment
eerimoq
left a comment
There was a problem hiding this comment.
Started testing =)
After installation a toast showing "Mic not found" is shown when starting the app. When upgrading the app users expects their previously selected mic to still be selected.
The view that opens when tapping the mic selection quick button no long closes automatically when selecting mic. I think it still should do that as most of the time the user will tap the correct mic, and don't want to tap close as well.
Starting Moblin with an external mic plugged it does not automatically select it. Plugging in the external mic with Moblin running does. Not sure how to best handle this.
This reverts commit f4026d7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mic settings are now saved to database even if RTMP audio is selected