Fix windows support, replace the readline with pyreadline3#8
Merged
efJerryYang merged 3 commits intomainfrom Mar 26, 2023
Merged
Fix windows support, replace the readline with pyreadline3#8efJerryYang merged 3 commits intomainfrom
readline with pyreadline3#8efJerryYang merged 3 commits intomainfrom
Conversation
We can use `pyreadline3` instead of the default `readline` module, and you can refer to the stackoverflow question for more details: https://stackoverflow.com/questions/51157443/pythons-readline-module-not-available-for-windows
Directly use the way on Linux will cause the prompt on windows with a duplicate input line string just after the correct prompt. This is caused by the `readline.get_line_buffer()`, and it should be used for clearing the cache rather than concatenating with the prompt string.
efJerryYang
force-pushed
the
fix-windows-support
branch
from
a3e7757 to
49569f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.