TASK-2026-00406: Processed only new trip sheet rows in Monthly Consolidated Trip Sheet and prevent duplicate journal entry creation#1459
Merged
MhmdSinanKT merged 1 commit intodevelopfrom Mar 26, 2026
Conversation
…Sheet and prevent duplicate jounal entry creation
MhmdSinanKT
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature description
Need to: Process only new trip sheet rows in Monthly Consolidated Trip Sheet and prevent duplicate journal entry creation
Solution description
Add fields:
is_processed (Check, default = 0)
processed_in_jv (Link to Journal Entry) in monthly_consolidated_trip_sheet_details child table
a flag (is_processed) to indicate whether it has already been included in a JV
a reference (processed_in_jv) to store the Journal Entry in which it was processed
When creating a Journal Entry:
only rows marked as unprocessed are selected
totals are calculated based only on these rows
after successful JV creation, those rows are marked as processed and linked to the created JV
already processed trip sheets are excluded
trip sheets already added in the current document are also excluded
Output screenshots (optional)
Screencast.from.26-03-26.01.05.09.PM.IST.webm
Screencast.from.26-03-26.01.06.28.PM.IST.webm
Areas affected and ensured
monthly consolidated trip sheet doctype
Is there any existing behaviour change of other features due to this code change?
No.
Was this feature tested on these browsers?