Skip to content

fix: Permission issue occurs while employee checkout #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MhmdSinanKT merged 1 commit into from
Feb 20, 2025
Merged

fix: Permission issue occurs while employee checkout #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions beams/beams/custom_scripts/leave_allocation/leave_allocation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def create_new_log_on_update(doc, method):
"start_date": start_date,
"end_date": end_date,
})
log_doc.insert()
log_doc.insert(ignore_permissions=True)


def create_new_compensatory_leave_log(doc, method):
Expand Down Expand Up @@ -114,7 +114,7 @@ def create_new_compensatory_leave_log(doc, method):
"start_date": start_date,
"end_date": end_date,
})
log_doc.insert()
log_doc.insert(ignore_permissions=True)



Expand All @@ -128,15 +128,15 @@ def validate(doc, method):
is allowed for the employee's gender. If the leave type is not listed in the mapping,
no validation is performed.
"""

employee_gender = frappe.db.get_value('Employee', doc.employee, 'gender')

if not employee_gender:
frappe.throw("Gender not found for Employee {employee}. Please ensure gender is set in the Employee record.".format(employee=doc.employee ))

is_leave_type_mapped = frappe.db.exists('Gender Leave Type Mapping', {'leave_type': doc.leave_type})


if is_leave_type_mapped:
is_valid_mapping = frappe.db.exists(
'Gender Leave Type Mapping',
Expand All @@ -146,7 +146,7 @@ def validate(doc, method):
}
)


if not is_valid_mapping:
frappe.throw(
"The Selected Leave Type '{leave_type}' is not permitted for Employee {employee} "
Expand All @@ -156,6 +156,3 @@ def validate(doc, method):
gender=employee_gender
)
)