chore: update @tanstack/vue-form to 1.32.0#755
Merged
Conversation
…TaggedUnion component to use 'tag' instead of 'state'
Contributor
There was a problem hiding this comment.
Pull request overview
Updates @tanstack/vue-form in @effect-app/vue-components to ^1.32.0, and refactors OmegaTaggedUnion rendering to be driven by a tag value read from the form store.
Changes:
- Bump
@tanstack/vue-formdependency to^1.32.0and update the lockfile to the new transitive versions. - Refactor
OmegaTaggedUnionInternalandOmegaTaggedUnionto usetag/currentTaginstead ofstatefor branch selection. - Add a changeset for a minor release of
@effect-app/vue-components.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates resolved versions for @tanstack/vue-form and its transitive deps; also changes one Effect tarball resolution entry. |
| packages/vue-components/package.json | Bumps @tanstack/vue-form to ^1.32.0. |
| packages/vue-components/src/components/OmegaForm/OmegaTaggedUnion.vue | Switches template branching from inputProps.state.value to currentTag. |
| packages/vue-components/src/components/OmegaForm/OmegaTaggedUnionInternal.vue | Renames the prop and slot bindings from state to tag. |
| .changeset/cool-needles-wash.md | Declares a minor changeset describing the dependency bump and refactor. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/vue-components/src/components/OmegaForm/OmegaTaggedUnionInternal.vue:24
- This component is re-exported from
components/OmegaForm/index.ts, so renaming the prop fromstatetotagis a public API change. Consider keepingstateas a backwards-compatible alias (and/or accepting both props) to avoid breaking external consumers, or bump the package with a breaking semver release.
const props = defineProps<{
tag: string | null
field: OmegaFieldInternalApi<From, Name>
name?: DeepKeys<From>
form: ReturnType<typeof useOmegaForm<From, To>>
}>()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| '@effect/platform-node-shared@https://pkg.pr.new/Effect-TS/effect-smol/@effect/platform-node-shared@a42ef66': | ||
| resolution: {integrity: sha512-Zsz7f5F6Hbgd5QJ2GiGpo7joQHDs87Z8fF2494S4VVRukZCLPopnB2ENCsnPFwTmR6kLgX/rNaych7lDBIzP3g==, tarball: https://pkg.pr.new/Effect-TS/effect-smol/@effect/platform-node-shared@a42ef66} | ||
| resolution: {tarball: https://pkg.pr.new/Effect-TS/effect-smol/@effect/platform-node-shared@a42ef66} |
| v-bind="{ field, state }" | ||
| v-if="tag" | ||
| :name="`${name ? `${name}.` : ''}${tag}`" | ||
| v-bind="{ field, tag }" |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@effect-app/vue-components": minor | |||
Comment on lines
84
to
88
| <OmegaTaggedUnionInternal | ||
| :field="inputProps.field as any" | ||
| :state="inputProps.state.value" | ||
| :tag="currentTag" | ||
| :name="name" | ||
| :form="form" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosa
Updates
@tanstack/vue-formda^1.23.5a^1.32.0.