feat(enforce-exhaustive-useUnit-destructuring): add new rule for destructured units#175
Conversation
✅ Deploy Preview for eslint-plugin ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ddd9966 to
9accf5e
Compare
9accf5e to
6c9cd69
Compare
80edafd to
e8e65b7
Compare
kireevmp
left a comment
There was a problem hiding this comment.
@Olovyannikov Thanks for taking the time to submit this! The rule logic seems to be solid 👍
There are a couple of good opportunities to improve this though – I'd appreciate it if you can take a look at my comments
8676017 to
61efbe7
Compare
23f77aa to
ed112f1
Compare
ed112f1 to
aa98a41
Compare
kireevmp
left a comment
There was a problem hiding this comment.
@Olovyannikov Thank you for committing your time to polish this PR! I think these are just final cosmetic touches on code location and consistency. Once fixed I believe we'll be in good shape to merge.
9a8b0c5 to
4c53dde
Compare
kireevmp
left a comment
There was a problem hiding this comment.
@Olovyannikov Thank you! I think I just need a changeset from you via pnpm changeset (changelog purposes, looking at a minor here). Once added this is good to merge 🚀
dbd9fc8 to
b8243b7
Compare
|
@Olovyannikov Thanks for seeing this through! I'll be taking a look at #176 as well in the next couple of days to wrap up this rule duo – we're currently aiming to release both in |
Problem: implicit subscriptions when forgot remove unused subscriptions inside react components
e.g.:
Why is this important?
Implicit subscriptions can lead to:
Rule Details
This rule enforces that: