no-units-spawn-in-render#180
Merged
Merged
Conversation
✅ Deploy Preview for eslint-plugin ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kireevmp
reviewed
Apr 9, 2026
Comment on lines
+176
to
+182
| function getCalleeName(callee: Node.CallExpression["callee"]): string | null { | ||
| if (callee.type === AST_NODE_TYPES.Identifier) return callee.name | ||
| if (callee.type === AST_NODE_TYPES.MemberExpression && callee.property.type === AST_NODE_TYPES.Identifier) { | ||
| return callee.property.name | ||
| } | ||
| return null | ||
| } |
Contributor
There was a problem hiding this comment.
These checks for AST_NODE_TYPES are duplicated across the rule implementation, so it might be beneficial to
- Either narrow this down on a
esqueryselector level to remove unrelated work altogether, or - Expand the logic to both check and format the name for a more nested structure (there's no reason to exclude
a.b.c()while includinga.b())
p.s. This might also help make these names prettier by including full path. Currently domain.event() produces just event in an error, but it might be nice to have domain.event.
AlexandrHoroshih
force-pushed
the
next-release-april-2026
branch
from
adf99f3 to
0f85d3b
Compare
AlexandrHoroshih
force-pushed
the
next-release-april-2026
branch
from
0f85d3b to
bf6b6ad
Compare
kireevmp
reviewed
Apr 9, 2026
| // `useContext` is excluded because it legitimately retrieves pre-created units. | ||
| // - Namespaced effector calls (e.g. `effector.createStore`) are matched | ||
| // by callee type against the effector package | ||
| // - Anything remaining is treated as a custom factory |
Contributor
There was a problem hiding this comment.
Note for future: this directly conflicts with third-party "model" providers, like effector-factorio with its factory.useModel(). Do we recommend disabling the rule for these users, or do we make the rule configurable?
Member
Author
There was a problem hiding this comment.
Good call
I think, we may add an exception ahead of time for that
kireevmp
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.