Skip to content

Display number of displayed times on Kapten Alloc#2

Merged
eflisback merged 4 commits into
mainfrom
kaptenallocdisplaycount
Oct 10, 2025
Merged

Display number of displayed times on Kapten Alloc#2
eflisback merged 4 commits into
mainfrom
kaptenallocdisplaycount

Conversation

@Poiku
Copy link
Copy Markdown
Collaborator

@Poiku Poiku commented Oct 6, 2025

No description provided.

@Poiku
Copy link
Copy Markdown
Collaborator Author

Poiku commented Oct 6, 2025

Makes the other sections in the header shift when it changes, needs to be fixed

@eflisback
Copy link
Copy Markdown
Owner

Perhaps use span here since it's no paragraph.

Reducing the max-width of the input element may solve the width issue.

Maybe it's cleaner to use .toString instead of string interpolation? I'm not sure.

@Poiku
Copy link
Copy Markdown
Collaborator Author

Poiku commented Oct 6, 2025

Maybe it's cleaner to use .toString instead of string interpolation? I'm not sure.

Yes the string interpolation was left over from when there was more text, it should be entries.length.toString

@Poiku
Copy link
Copy Markdown
Collaborator Author

Poiku commented Oct 10, 2025

@eflisback I have now put the text inside the search box, seems to look pretty good on desktop and mobile
image

@eflisback eflisback force-pushed the kaptenallocdisplaycount branch from 19fad94 to 9b54f6b Compare October 10, 2025 11:33
@eflisback
Copy link
Copy Markdown
Owner

Looks good! A bit hacky with the negative margin for positioning, but I think it's okay! I changed the p tag to a span one and updated the variable name. Will now merge 👍

@eflisback eflisback merged commit 52402f4 into main Oct 10, 2025
@eflisback eflisback deleted the kaptenallocdisplaycount branch October 10, 2025 11:39
@Poiku
Copy link
Copy Markdown
Collaborator Author

Poiku commented Oct 10, 2025

Yeah the negative margin was the only solution i found that worked okay with scaleable window width and on phones, there is probably a better solution 🙃🙃🙃🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants