Refactor https-dns-proxy init script for nftables#1
Merged
Conversation
The problem from issue mossdef-org#7 is solved 👍 Some small remaining things: Every time the firewall restarts there are duplicate nft rules. A better approach might be to add the table and then flush it. Furthermore seeing line https://github.com/mossdef-org/https-dns-proxy/blob/64d18e172fbbe79ee1695bcf32e62658f700c7c1/files/etc/init.d/https-dns-proxy#L166 makes me think you have added it for error tracking? In that case you might need to add code when that is called see my last proposed change Signed-off-by: Erik Conijn <egc112@msn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem from issue mossdef-org#7 is solved 👍
Some small remaining things:
Every time the firewall restarts there are duplicate nft rules.
A better approach might be to add the table and then flush it.
Furthermore seeing line https://github.com/mossdef-org/https-dns-proxy/blob/64d18e172fbbe79ee1695bcf32e62658f700c7c1/files/etc/init.d/https-dns-proxy#L166 makes me think you have added it for error tracking?
In that case you might need to add code when that is called see my last proposed change