Skip to content

Pave path to technically allow PATCH requests #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2015
Merged

Pave path to technically allow PATCH requests #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/EchoIt/JsonApi/Handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ public static function successfulHttpStatusCode($method, $model = null)
// if we did a put request, we need to ensure that the model wasn't
// changed in other ways than those specified by the request
// Ref: http://jsonapi.org/format/#crud-updating-responses-200
if ($method === 'PUT' && $model instanceof Model) {
if (($method === 'PATCH' || $method === 'PUT') && $model instanceof Model) {
// check if the model has been changed
if ($model->isChanged()) {
// return our response as if there was a GET request
Expand All @@ -288,6 +288,7 @@ public static function successfulHttpStatusCode($method, $model = null)
switch ($method) {
case 'POST':
return BaseResponse::HTTP_CREATED;
case 'PATCH':
case 'PUT':
case 'DELETE':
return BaseResponse::HTTP_NO_CONTENT;
Expand All @@ -296,7 +297,7 @@ public static function successfulHttpStatusCode($method, $model = null)
}

// Code shouldn't reach this point, but if it does we assume that the
// client has made a bad request, e.g. PATCH
// client has made a bad request.
return BaseResponse::HTTP_BAD_REQUEST;
}

Expand Down