docs(bundler): document manifest dynamic entries#5928
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughBundler docs now state that when a missing ChangesDocumentation: Startup Manifest and Dynamic Entry Recording
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Deploying egg with
|
| Latest commit: |
3e4da91
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7708c5fa.egg-cci.pages.dev |
| Branch Preview URL: | https://agent-egg-doc-beef8554.egg-cci.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR updates @eggjs/egg-bundler documentation to clarify how manifest auto-generation in metadataOnly mode captures convention-based dynamic file lookups so bundled single-mode workers can resolve agent hooks, extensions, and middleware at runtime.
Changes:
- Document that manifest generation in
metadataOnly: truerecords conventional dynamic entries across load units. - Explain the practical impact for bundled single-mode workers (agent hooks,
app/extend,app/middlewareresolution).
Deploying egg-v3 with
|
| Latest commit: |
3e4da91
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2b2462c9.egg-v3.pages.dev |
| Branch Preview URL: | https://agent-egg-doc-beef8554.egg-v3.pages.dev |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the egg-bundler output structure to explain the behavior when generating a missing startup manifest with metadataOnly set to true. It describes how convention-based dynamic entries are recorded to support single-mode workers in resolving plugin hooks and middleware. I have no feedback to provide on these changes.
Summary
.egg/manifest.jsonrecords these lookups intoresolveCacheandfileDiscoveryso bundled single-mode workers can resolve plugin agent hooks, extensions, and middleware discovered during runtime loading.Validation
Summary by CodeRabbit