fix(agent-tracing): add eggModule declaration for tegg module scanning#416
fix(agent-tracing): add eggModule declaration for tegg module scanning#416jerryliang64 merged 2 commits intomasterfrom
Conversation
Without the eggModule field in package.json, tegg does not scan @eggjs/agent-tracing for SingletonProto classes (ClaudeAgentTracer, TracingService), making them unavailable for dependency injection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded a top-level Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow the naming convention of other @eggjs packages (tegg prefix). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
eggModuledeclaration to@eggjs/agent-tracingpackage.json so that tegg can scan and registerClaudeAgentTracerandTracingServiceas DI prototypes.@Inject()ClaudeAgentTracer getEGG_PROTO_NOT_FOUNDerror because tegg never discovers the@SingletonProtoclasses in this package.Test plan
@eggjs/agent-tracingand registersClaudeAgentTracer/TracingServiceprototypes@Inject() claudeAgentTracer: ClaudeAgentTracerworks in consuming app🤖 Generated with Claude Code
Summary by CodeRabbit