Skip to content

fix(agent-tracing): add eggModule declaration for tegg module scanning#416

Merged
jerryliang64 merged 2 commits intomasterfrom
fix/agent-tracing-egg-module
Mar 27, 2026
Merged

fix(agent-tracing): add eggModule declaration for tegg module scanning#416
jerryliang64 merged 2 commits intomasterfrom
fix/agent-tracing-egg-module

Conversation

@jerryliang64
Copy link
Copy Markdown
Contributor

@jerryliang64 jerryliang64 commented Mar 26, 2026

Summary

  • Add eggModule declaration to @eggjs/agent-tracing package.json so that tegg can scan and register ClaudeAgentTracer and TracingService as DI prototypes.
  • Without this, consuming apps that @Inject() ClaudeAgentTracer get EGG_PROTO_NOT_FOUND error because tegg never discovers the @SingletonProto classes in this package.

Test plan

  • Verify tegg scans @eggjs/agent-tracing and registers ClaudeAgentTracer / TracingService prototypes
  • Verify @Inject() claudeAgentTracer: ClaudeAgentTracer works in consuming app

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated module configuration metadata to include a top-level module name. This is a non-functional metadata change with no impact on public APIs or runtime behavior. Review effort: low.

Without the eggModule field in package.json, tegg does not scan
@eggjs/agent-tracing for SingletonProto classes (ClaudeAgentTracer,
TracingService), making them unavailable for dependency injection.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ed4d955b-0527-4c92-add6-6ceb31f66620

📥 Commits

Reviewing files that changed from the base of the PR and between 0739b81 and 098d221.

📒 Files selected for processing (1)
  • core/agent-tracing/package.json
✅ Files skipped from review due to trivial changes (1)
  • core/agent-tracing/package.json

📝 Walkthrough

Walkthrough

Added a top-level eggModule object to core/agent-tracing/package.json with name: "teggAgentTracing". No other package metadata, dependencies, scripts, exports, or engines were changed.

Changes

Cohort / File(s) Summary
Package Configuration
core/agent-tracing/package.json
Insert top-level eggModule metadata with name: "teggAgentTracing".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • fengmk2

Poem

🐰 A small new name I gently bring,
"teggAgentTracing" — a metadata spring,
A hop, a nibble, tidy and bright,
Package whispers, all tucked up tight,
🍃🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding an eggModule declaration to enable tegg module scanning for the agent-tracing package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/agent-tracing-egg-module

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an eggModule configuration to the package.json for the agent-tracing package. The feedback suggests renaming the module to agentTracing to maintain consistency with other modules and avoid redundant naming.

Follow the naming convention of other @eggjs packages (tegg prefix).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@akitaSummer akitaSummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

@jerryliang64 jerryliang64 merged commit d169cab into master Mar 27, 2026
12 checks passed
@jerryliang64 jerryliang64 deleted the fix/agent-tracing-egg-module branch March 27, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants