feat: improve parallel output rendering with per-output progress bars and explicit tests#286
Merged
szmyty merged 3 commits intoApr 11, 2026
Conversation
5 tasks
… and tests Agent-Logs-Url: https://github.com/egohygiene/renderflow/sessions/20715bbe-0279-4e3f-bd9f-d21808f1dd38 Co-authored-by: szmyty <14865041+szmyty@users.noreply.github.com>
…onstants Agent-Logs-Url: https://github.com/egohygiene/renderflow/sessions/20715bbe-0279-4e3f-bd9f-d21808f1dd38 Co-authored-by: szmyty <14865041+szmyty@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enable parallel execution of output strategies
feat: improve parallel output rendering with per-output progress bars and explicit tests
Apr 11, 2026
szmyty
approved these changes
Apr 11, 2026
Pull Request Summary by devActivityMetricsAchievements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel output rendering via Rayon's
par_iter()was already wired up, but calledMultiProgress::add()inside the parallel closure — acquiring an internal mutex on every call and potentially serializing workers. This PR eliminates that contention and adds explicit validation of the parallel behavior.Changes
Pre-create per-output progress bars before the rayon section, then zip with outputs:
create_output_bar()helper extracts bar creation logic and documents the pre-creation rationaleNamed symbol constants (
SYMBOL_OK,SYMBOL_FAIL,SYMBOL_SKIP) replace hardcoded emoji strings across all render status messagesThree new tests covering the parallel execution acceptance criteria:
test_parallel_dry_run_produces_result_per_output—par_iterprocesses every configured outputtest_parallel_failure_isolation_and_aggregation— each format fails independently; all failures aggregated into one errortest_parallel_renders_all_formats_independently— HTML + PDF + DOCX render concurrently and all output files are produced