Conversation
|
I will need do little more here, as need be able to modify behaviour of ProcessEvents, will think about it and updat epr |
|
@ForNeVeR i had add interface behind Json client, that allows me fully track now behaviours in Receiver. However maybe you will have better ideas how to track how many events we receive receive from telegram |
ForNeVeR
left a comment
ForNeVeR
left a comment
There was a problem hiding this comment.
Also please fix the warnings/compilation issues (I think we have warnings-as-errors here?). Thanks!
TdLib/TdClient.cs
Outdated
| } | ||
| /// <param name="bindings">Bidings for the client to call functions of TDLib.</param> | ||
| /// <param name="receiverTimeOut">Timeout for <c>td_json_client_receive</c>.</param> | ||
| public TdClient(IReceiver receiver) |
There was a problem hiding this comment.
Please let's construct this in a way that will not produce copy-pasted code.
The standard solution I'd say is to have one "mega"-constructor with all three arguments, and perhaps several overloads as needed; all the overloads would delegate to the "mega"-constructor.
There was a problem hiding this comment.
will address it tomorrow. Today my mind already gave up
There was a problem hiding this comment.
I addressed it, however it didnt make sense to have 3 parameters, so final constructor is with IReceiver and all others adding parameters into it. as IReceiver already covers all other version of constructor, as we setup t/o on constructor :)
I see what you meant there, i corrected it now.
|
@ForNeVeR any idea why the test would stuck? I am more than happy to fix issues but locally it all passed lol |
|
@ForNeVeR i figure out my mistake, it is fixed now |
ForNeVeR
force-pushed
the
feature/allow-insertion-of-custom-receivers
branch
2 times, most recently
from
3049c7e to
ea59d88
Compare
ForNeVeR
force-pushed
the
feature/allow-insertion-of-custom-receivers
branch
from
ea59d88 to
9ce4607
Compare
ForNeVeR
left a comment
ForNeVeR
left a comment
There was a problem hiding this comment.
Thanks! I've adjusted the resulting API for a bit.
|
@ForNeVeR is there any chance you can push nuget package with our changes any time soon? |
|
Already in progress. |
2 participants
This is need to allow me to inject custom Receiver with Otel Metrics so i can track how many events we receive from telegram
Closes #169.