Skip to content

feat(env): add DeclaredGithubEnvironment for supply chain protection#37

Merged
uladkasach merged 7 commits intomainfrom
vlad/feat-github-environments
May 3, 2026
Merged

feat(env): add DeclaredGithubEnvironment for supply chain protection#37
uladkasach merged 7 commits intomainfrom
vlad/feat-github-environments

Conversation

@ehm-seaturtle
Copy link
Copy Markdown
Contributor

feat(env): add DeclaredGithubEnvironment for supply chain protection

  • domain object with reviewers, waitTimer, deploymentBranchPolicy, preventSelfReview
  • dao with get/set/del operations
  • user/team ID lookup from usernames
  • custom branch policy sync
  • acceptance tests with production-on-main and production-on-else environments
  • snapshot output with ESC character and whitespace handling

🐢🌊 surfed in by seaturtle[bot]

ehm-seaturtle and others added 7 commits May 2, 2026 06:51
- domain object with reviewers, waitTimer, deploymentBranchPolicy, preventSelfReview
- dao with get/set/del operations
- user/team ID lookup from usernames
- custom branch policy sync
- acceptance tests with production-on-main and production-on-else environments
- snapshot output with ESC character and whitespace handling

Co-authored-by: ulad kasach <uladkasach@gmail.com>
- multiline formatting for better readability

Co-authored-by: ulad kasach <uladkasach@gmail.com>
- biome requires biome-ignore, not eslint-disable-next-line
- intentional ESC character stripping for terminal output snapshots

Co-authored-by: ulad kasach <uladkasach@gmail.com>
- biome-ignore must be directly above the line with the regex
- moved comments to correct position in method chain

Co-authored-by: ulad kasach <uladkasach@gmail.com>
- GITHUB_TOKEN is provided via secrets.GITHUB_TOKEN in CI
- keyrack with env.test keys fails in CI due to missing extended file
- using env.test: null avoids strict mode failure

Co-authored-by: ulad kasach <uladkasach@gmail.com>
- keyrack.source requires symlinks created by rhachet init
- without prepare:rhachet step, extends reference fails in CI
- pattern from ehmpathy/rhachet-brains-xai PR 21

Co-authored-by: ulad kasach <uladkasach@gmail.com>
- added path replacement to strip repo base paths from error output
- supports both local dev paths and CI runner paths
- snapshots now use <repo>/ placeholder instead of absolute paths

Co-authored-by: ulad kasach <uladkasach@gmail.com>
@uladkasach uladkasach merged commit 9dc38bd into main May 3, 2026
19 of 20 checks passed
@uladkasach uladkasach deleted the vlad/feat-github-environments branch May 3, 2026 20:07
@rhelease rhelease Bot mentioned this pull request May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants