fix(imports): eliminate circular dependencies with type-fns#35
Merged
uladkasach merged 1 commit intomainfrom Mar 18, 2026
Merged
fix(imports): eliminate circular dependencies with type-fns#35uladkasach merged 1 commit intomainfrom
uladkasach merged 1 commit intomainfrom
Conversation
- use scoped imports from type-fns to avoid barrel re-export cycle - collocate withHelpfulError into HelpfulError.ts to break local cycle - add dpdm lint check (test:lint:imports) to detect cycles including node_modules - add brief documenting forbidden barrel imports from type-fns Co-authored-by: Ulad Kasach <uladkasach@gmail.com>
Contributor
uladkasach
added a commit
to ehmpathy/declapract-typescript-ehmpathy
that referenced
this pull request
Mar 18, 2026
- add dpdm@4.0.1 as devDependency for cycle detection - add test:lint:cycles script using dpdm - include cycles check in test:lint pipeline ref: ehmpathy/helpful-errors#35 Co-authored-by: Ulad Kasach <uladkasach@gmail.com>
uladkasach
added a commit
to ehmpathy/declapract-typescript-ehmpathy
that referenced
this pull request
Mar 18, 2026
- add dpdm@4.0.1 as devDependency for cycle detection - add test:lint:cycles script using dpdm - include cycles check in test:lint pipeline ref: ehmpathy/helpful-errors#35 Co-authored-by: Ulad Kasach <uladkasach@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(imports): eliminate circular dependencies with type-fns
🐢🌊 surfed in by seaturtle[bot]