Add Tunnel Nodes system for managing remote nodes#5
Conversation
Co-authored-by: Ehsan <1883051+ehsanking@users.noreply.github.com>
Add database table, API, UI component, and migration script for managing remote nodes. Co-authored-by: Ehsan <1883051+ehsanking@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f690f2ec6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const remoteCommand = generateRemoteNodeCommand(node, mainServerIp || 'YOUR_MAIN_SERVER_IP', mainServerPort); | ||
| const mainCommand = generateMainServerCommand( | ||
| { ip: mainServerIp || 'YOUR_MAIN_SERVER_IP', port: mainServerPort }, | ||
| node.tunnel_type, |
There was a problem hiding this comment.
The command modal currently builds both setup commands with mainServerPort, so the per-node tunnel_port collected and stored for each node is ignored. If a node is configured with a non-default tunnel port (or nodes use different ports), the generated gost commands point to the wrong listener and tunnel setup fails or conflicts on port reuse.
Useful? React with 👍 / 👎.
| SELECT * FROM tunnel_nodes | ||
| ORDER BY created_at DESC |
There was a problem hiding this comment.
The list endpoint selects and returns all columns from tunnel_nodes, which includes tunnel_secret. This secret is the relay authentication credential used in generated commands, so exposing it in a broad list response allows anyone with API access to impersonate a tunnel node. The listing should omit tunnel_secret and only return it through a narrowly scoped privileged flow.
Useful? React with 👍 / 👎.
1 participant
server_addressfield to the inbound configuration form for enhanced connectivity options.v0 Session