Skip to content

Attach sample location data, include IP location in outputs, and add new providers#6

Merged
ehsanking merged 3 commits intomainfrom
ehsan/test-data-center-from-each-country-zhmmmq
Apr 2, 2026
Merged

Attach sample location data, include IP location in outputs, and add new providers#6
ehsanking merged 3 commits intomainfrom
ehsan/test-data-center-from-each-country-zhmmmq

Conversation

@ehsanking
Copy link
Copy Markdown
Owner

Motivation

  • Improve sampling accuracy by prioritizing location-aware test targets and surfacing IP location metadata in reports to help identify best paths.
  • Extend provider catalog and testing priority to include common European/US VPS providers for broader connectivity insights.
  • Make CLI and exported CSV/text outputs more informative by showing city/country where available.

Description

  • Added buildSampleTargets and changed testProviderConnectivity to use location-aware sample targets and attach location to connectivity results when available.
  • Enhanced convertToCsv and CLI printing in cli.js to include a Best IP Location column and conditionally print city/country for the best connection.
  • Added country and testLocations metadata to multiple provider groups and introduced new provider entries (hetzner_falkenstein_cx22, ovh_gravelines_starter, scaleway_paris_dev1s, vultr_fremont_regular, digitalocean_fra1_basic) in ip_ranges.js.
  • Updated default provider priority order in config_manager.js to include the new provider keys and adjusted printProviders to display country labels.

Testing

  • Ran unit test suite with npm test against connectivity sampling and CSV export logic and all tests passed.
  • Ran linter with npm run lint to validate formatting and no lint errors remained.
  • Executed the CLI analyze flow in an automated smoke test to ensure --detailed output and CSV export include the new location column and the test passed.

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b7c7c025b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cli.js Outdated
@ehsanking ehsanking merged commit d909a3d into main Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant