Skip to content

Conversation

@herrrta
Copy link
Contributor

@herrrta herrrta commented Oct 3, 2025

Copy link
Owner

@ehsannarmani ehsannarmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @herrrta , thanks for contributing and adding this feature.
First, i think the confirmDraw name for that lambda is better than canDrawPoint
Second, i think having the dataIndex in that lambda would be usefull (imagine you have two lines, in the first line you want draw all of points, but in other lines, you want just draw first and last point, here it can be usefull)
Third, i think if default value would true, is better than nullable lambda:

val confirmDraw: (dataIndex:Int,valueIndex: Int, value: Double) -> Boolean = { true }

@herrrta herrrta force-pushed the herrrta/feat/draw-specific-dots branch from 6031c58 to fc098b6 Compare October 3, 2025 20:31
@herrrta
Copy link
Contributor Author

herrrta commented Oct 3, 2025

All done

@herrrta herrrta requested a review from ehsannarmani October 3, 2025 20:31
@ehsannarmani
Copy link
Owner

thanks

@ehsannarmani ehsannarmani merged commit b65e832 into ehsannarmani:master Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to specify what dots should be drawn

2 participants