[pull] main from reactiveui:main#87
Merged
pull[bot] merged 2 commits intoehtick:mainfrom Dec 17, 2023
Merged
Conversation
#3695) …as no browsable, no displayable, no autogenerateable and no autofilterable for Winforms control databindings (and possibly for WPF controls too) Fixes #3694 **What kind of change does this PR introduce?** Assign new attributes on Observable properties for better hiding from Winforms/WPF **What is the current behavior?** Those properties are autogenerated as controls **What is the new behavior?** Those properties are ignored as controls **What might this PR break?** **Please check if the PR fulfills these requirements** - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) **Other information**: --------- Co-authored-by: Michael-Jorge Gómez Campos <michael.gomez@rosclar.com>
Fixes #3682 <!-- Please be sure to read the [Contribute](https://github.com/reactiveui/reactiveui#contribute) section of the README --> **What kind of change does this PR introduce?** <!-- Bug fix, feature, docs update, ... --> **What is the current behavior?** <!-- You can also link to an open issue here. --> **What is the new behavior?** <!-- If this is a feature change --> For deferred subscriptions in OAPH 2 changes where made: - On first `Value` access INPC is no longer emitted while the `Value` is still the initial value. - After accessing `Value` for the first time, INPC is no longer emitted if the value produced from source is the same as the initial value **What might this PR break?** I don't think anything will break. It doesn't make sense for any UI framework to subscribe to INPC without reading the initial value anyway. **Please check if the PR fulfills these requirements** - [x] Tests for the changes have been added (for bug fixes / features) - [x] Docs have been added / updated (for bug fixes / features) **Other information**: --------- Co-authored-by: amr <amr.al.sayed@cmaster-eg.com> Co-authored-by: Chris Pulman <chris.pulman@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )