Skip to content

Conversation

@mhkim-anl
Copy link

@mhkim-anl mhkim-anl commented Nov 23, 2025

Briefly, what does this PR introduce?

This PR introduces a data model for the CALOROC1B chip. Although it is not yet available in hardware, it is, together with the HGCROC chip, a strong candidate for the calorimeter readout in the ePIC experiment. Having a dedicated CALOROC1B data model allows us to study its expected performance in detail. The performance not only can be directly compared with the HGCROC-based performance, but also provide useful input for the CALOROC1B chip development.

Since the main difference between the CALOROC1B and HGCROC (CALOROC1A) chip is whether the chip has TOT or low gain ADC, the data model has been implemented based on edm4eic::HGCROCSample and edm4eic::RawHGCROCHit.

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@ruse-traveler
Copy link
Contributor

ruse-traveler commented Nov 26, 2025

Hi all, I wanted to record action items from the 11.25.2025 BIC Simulation Meeting. Let me know if anything's missing/incorrect/misrepresentative!

  • Combine existing RawHGCROCHit type with proposed RawCaloroc1BHit type
  • Add new vector member for Caloroc1BSample component

Then I can't remember if we explicitly talked about this in the meeting, but it might make sense to rename HGCROCSample and RawHGCROCHit to CALOROC1ASample and RawCALOROCHit respectively...

@veprbl
Copy link
Member

veprbl commented Nov 26, 2025

HGCROC is not the same as CALOROC1A?

@veprbl
Copy link
Member

veprbl commented Nov 26, 2025

If yes, then what is the better name? RawROCHit?

@ruse-traveler
Copy link
Contributor

HGCROC is not the same as CALOROC1A?
If yes, then what is the better name? RawROCHit?

Ah! Then I may have misunderstood the discussion... What's the difference between the 1A and the HGC?
I think RawROCHit's a good name if they are different, though!

@mhkim-anl
Copy link
Author

Thank you very much for arranging the action items and for the discussion on the name of the data model! If I remember correctly, the data structure of the HGCROC chip is as same as the CALOROC1A (I'll cross-check this point). So I've updated the edm4eic.yml accordingly. Please let me know if I've misunderstood anything from the last simulation meeting.

@veprbl
Copy link
Member

veprbl commented Nov 30, 2025

Can somebody confirm whether HGCROC and CALOROC1A have the same fields?

@mandrenguyen
Copy link

Yes, I think the same data structure is appropriate. The CALOROCA will have a different number of channels and will be adapted for the EIC clock, but it will have the same format (ADC/TOT/TOA). The CALOROCB will instead by dual-gain ADC (no TOT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CALOROC type B data structure

5 participants