fix: Add ImagingTopoCluster layer mode within same layers #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: calorimetry
wdconinc
reviewed
Aug 5, 2025
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
In this PR, a new phiz layermode is introduced in the Imaging Topological Clustering Algorithm to group hits both within the same layer and across different layers.
The impact of these changes is studied using a 2-photon simulation, and the corresponding plots are attached. |
veprbl
reviewed
Aug 16, 2025
7 tasks
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
wdconinc
reviewed
Aug 21, 2025
There was a problem hiding this comment.
To avoid initialization order errors (https://github.com/eic/EICrecon/actions/runs/17133996414/job/48605273777?pr=1999#step:7:624) and to avoid having to sometimes have diff first and sometimes same, this reorders the config ordering so the algorithms will always have same first, then diff next.
May need changes in FHCAL or ZDC, I didn't verify that.
AkshayaVijay
temporarily deployed
to
github-pages
GitHub Actions
Inactive
veprbl
previously approved these changes
Aug 28, 2025
There was a problem hiding this comment.
Diff looks good to me. Capybara report shows no changes to ZDC, as expected. https://eicrecon.epic-eic.org/pr/1999/capybara/rec_dis_18x275_minQ2=1000_craterlake_18x275/index.html#HcalFarForwardZDCClusters
wdconinc
added a commit
that referenced
this pull request
Aug 28, 2025
…wyu) (#2056) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/17303800492. Please merge this PR into the branch `Test-Layermodes-within-same-layers-for-ImagingTopo-Clusters` to resolve failures in PR #1999. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wdconinc
reviewed
Aug 28, 2025
wdconinc
reviewed
Aug 28, 2025
wdconinc
reviewed
Aug 28, 2025
wdconinc
reviewed
Aug 28, 2025
wdconinc
reviewed
Aug 28, 2025
wdconinc
reviewed
Aug 28, 2025
for more information, see https://pre-commit.ci
…wyu) (#2056) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/17303800492. Please merge this PR into the branch `Test-Layermodes-within-same-layers-for-ImagingTopo-Clusters` to resolve failures in PR #1999. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
wdconinc
force-pushed
the
Test-Layermodes-within-same-layers-for-ImagingTopo-Clusters
branch
from
b5e8f4f to
9959c45
Compare
|
Rebased for #2057. |
wdconinc
approved these changes
Aug 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2025
#2015) ### Briefly, what does this PR introduce? This PR modifies the unscoped enum `ESigmaMode` to a scoped enum, and avoids the implicit integer conversion by correcting the `operator<<` signature. Before this fix, the output was `0` or `1` (since the incorrectly-signatured `operator<<` is not used); after this fix, the output is `abs` or `rel`. The scoping of the enum adds a layer of safety since the symbol `abs` could previously shadow the standard function `std::abs`. This aligns with the enabled clang-tidy check `cppcoreguidelines-use-enum-class`, https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/use-enum-class.html. ### What kind of change does this PR introduce? - [x] Bug fix (issue: #1999 (comment), but fails to compile #1999 (comment)) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
wdconinc
deleted the
Test-Layermodes-within-same-layers-for-ImagingTopo-Clusters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Added Layer Modes to the helper function to group hits within the same layer for ImagingTopoCluster
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?