fix: enable strongly-typed enum SiliconChargeSharingConfig::ESigmaMode #2015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR modifies the unscoped enum
ESigmaMode
to a scoped enum, and avoids the implicit integer conversion by correcting theoperator<<
signature. Before this fix, the output was0
or1
(since the incorrectly-signaturedoperator<<
is not used); after this fix, the output isabs
orrel
.The scoping of the enum adds a layer of safety since the symbol
abs
could previously shadow the standard functionstd::abs
.This aligns with the enabled clang-tidy check
cppcoreguidelines-use-enum-class
, https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/use-enum-class.html.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.