Skip to content

fix: enable strongly-typed enum SiliconChargeSharingConfig::ESigmaMode #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2025
Merged

fix: enable strongly-typed enum SiliconChargeSharingConfig::ESigmaMode #2015

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9ddd41
demo: strongly-typed enum SiliconChargeSharingConfig::ESigmaMode
wdconinc Aug 16, 2025
330dcae
Change operator<< to accept const reference for ESigmaMode
wdconinc Aug 29, 2025
79ca18c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/algorithms/digi/SiliconChargeSharingConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ struct SiliconChargeSharingConfig {
// determines the meaning of sigma_sharingx and y.
// rel means relative, so charge sharing range = sigma_sharingx * cell_width_x, etc for y
// abs means absolute, charge sharing range = sigma_shargeingx directly
enum ESigmaMode { abs = 0, rel = 1 } sigma_mode = abs;
enum class ESigmaMode { abs = 0, rel = 1 } sigma_mode = ESigmaMode::abs;
float sigma_sharingx;
float sigma_sharingy;
float min_edep;
Expand All @@ -31,7 +31,8 @@ std::istream& operator>>(std::istream& in, SiliconChargeSharingConfig::ESigmaMod

return in;
}
std::ostream& operator<<(std::ostream& out, SiliconChargeSharingConfig::ESigmaMode& sigmaMode) {
std::ostream& operator<<(std::ostream& out,
const SiliconChargeSharingConfig::ESigmaMode& sigmaMode) {
switch (sigmaMode) {
case SiliconChargeSharingConfig::ESigmaMode::abs:
out << "abs";
Expand Down
Loading