chore: remove mt.h (last users migrated to ROOT::EnableImplicitMT())#4
Merged
chore: remove mt.h (last users migrated to ROOT::EnableImplicitMT())#4
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the now-unused include/common_bench/mt.h header that hardcoded a fixed thread count, aligning common_bench with the repo’s broader move to ROOT::EnableImplicitMT() without an explicit thread number.
Changes:
- Delete
include/common_bench/mt.h(hardcodedkNumThreads = 8).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
force-pushed
the
remove-mt-header
branch
from
05687a8 to
3011acd
Compare
mt.h defined a single compile-time constant (kNumThreads = 8) intended to control ROOT's implicit multithreading. It was ignored by the majority of analysis scripts, which already used ROOT::EnableImplicitMT() with no argument. The three remaining users in physics_benchmarks have now been updated to use the no-arg form. The header's own TODO noted it should be made configurable via CI scripts — that is now moot since auto-detection is the correct approach. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wdconinc
force-pushed
the
remove-mt-header
branch
from
3011acd to
845fc9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include/common_bench/mt.his now unused. The three scripts inphysics_benchmarksthat previously calledROOT::EnableImplicitMT(kNumThreads)have been updated toROOT::EnableImplicitMT()(see companion PR eic/physics_benchmarks#95).Why this is correct
mt.hdefinedconstexpr int kNumThreads = 8— a hardcoded value that:$BENCHMARK_N_THREADSfromenv.sh(CI default: 10)Changes
include/common_bench/mt.h(11 lines)Related
Part of an ongoing audit to streamline
common_benchusage:clipp.h