Skip to content

ci: add capybara artifact comparisons to benchmark jobs#254

Merged
wdconinc merged 2 commits intocapybarafrom
capybara-compare
Apr 24, 2026
Merged

ci: add capybara artifact comparisons to benchmark jobs#254
wdconinc merged 2 commits intocapybarafrom
capybara-compare

Conversation

@wdconinc
Copy link
Copy Markdown
Contributor

Summary

Adds capybara comparison steps to all four benchmark jobs introduced in #253, plus a merge-capybara job that combines the per-job reports into a single downloadable artifact.

Depends on #253 — open against the capybara branch; will be retargeted to master automatically when #253 merges.

What this adds to each benchmark job

After the simulation/reconstruction artifact is uploaded, each job:

  1. Downloads the reference artifact from the base branch using dawidd6/action-download-artifact@v20 (warns and continues if not yet available)
  2. Runs capybara bara to compare the current output against the reference
  3. Uploads a .capy artifact (comparison reports directory + sentinel file)

A final merge-capybara job merges all four .capy artifacts into a single capybara-report artifact.

Workflow trigger change

The pull_request trigger no longer restricts to branches: [master] — it fires on PRs to any branch (including capybara), so this PR itself exercises the full pipeline.

Copilot AI review requested due to automatic review settings April 24, 2026 00:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds capybara artifact comparison and report aggregation to the benchmark CI jobs so PR outputs can be compared against the base branch and downloaded as a single merged report.

Changes:

  • Removes the pull_request trigger branch restriction so the workflow runs on PRs targeting any branch.
  • Adds “download reference artifact → run capybara bara → upload .capy report artifact” steps to all four benchmark jobs.
  • Introduces a merge-capybara job that merges per-job .capy artifacts into a single capybara-report artifact.

Comment thread .github/workflows/build-push.yml
Comment thread .github/workflows/build-push.yml
Comment thread .github/workflows/build-push.yml
Comment thread .github/workflows/build-push.yml
Comment thread .github/workflows/build-push.yml
wdconinc and others added 2 commits April 23, 2026 19:29
For each of the four benchmark jobs (npsim-gun, npsim-dis, eicrecon-gun,
eicrecon-dis), add after the artifact upload:

1. Download the previous artifact from the base branch using
   dawidd6/action-download-artifact@v20
2. Run 'capybara bara' to compare current output against the reference
3. Upload a .capy artifact containing the comparison reports

Add a merge-capybara job that combines all *.capy artifacts into a
single capybara-report artifact for easy consumption.

This PR should be opened after the npsim/eicrecon benchmarks PR merges
to master, so that the base-branch artifacts exist as reference.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the 'branches: [master]' filter from the pull_request trigger
so that the benchmark jobs (including capybara comparisons) also fire
on PRs targeting capybara or any other branch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@wdconinc wdconinc merged commit b8ef353 into capybara Apr 24, 2026
42 checks passed
@wdconinc wdconinc deleted the capybara-compare branch April 24, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants