Skip to content

fix: (py-)protobuf: v*.28.{2 -> 3}#265

Merged
wdconinc merged 3 commits intomasterfrom
protobuf-28.3
May 8, 2026
Merged

fix: (py-)protobuf: v*.28.{2 -> 3}#265
wdconinc merged 3 commits intomasterfrom
protobuf-28.3

Conversation

@wdconinc
Copy link
Copy Markdown
Contributor

@wdconinc wdconinc commented May 5, 2026

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

TensorFlow vendors protobuf 5.28.3, and a runtime version consistency check causes TensorFlow to fail to load. This PR ensures that protobuf is at the right version.

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

What kind of change does this PR introduce?

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

Copilot AI review requested due to automatic review settings May 5, 2026 22:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the pinned (py-)protobuf versions in the Spack environment to align with TensorFlow’s vendored protobuf 5.28.3, avoiding TensorFlow’s runtime protobuf version consistency check failure.

Changes:

  • Bump protobuf from @28.2 to @28.3.
  • Bump py-protobuf from @5.28.2 to @5.28.3.

@wdconinc wdconinc enabled auto-merge (squash) May 6, 2026 03:27
@wdconinc wdconinc requested a review from a team May 6, 2026 03:27
Copy link
Copy Markdown

@ruse-traveler ruse-traveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wdconinc
Copy link
Copy Markdown
Contributor Author

wdconinc commented May 7, 2026

Needs #268 first...

@ruse-traveler
Copy link
Copy Markdown

Needs #268 first...

Whoops! 😅

Copilot AI review requested due to automatic review settings May 8, 2026 00:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@wdconinc
Copy link
Copy Markdown
Contributor Author

wdconinc commented May 8, 2026

@tonnysoyyo This should finally merge today I hope. Then try the workflow again.

@wdconinc wdconinc disabled auto-merge May 8, 2026 23:09
@wdconinc wdconinc merged commit 79cf9a4 into master May 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants